Code review comment for lp:~dimitern/juju-core/001-upgrade-charm-filter-restart-watchers

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Please take a look.

https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go
File worker/uniter/filter.go (right):

https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go#newcode144
worker/uniter/filter.go:144: // pending relation changes.
On 2013/02/22 11:25:33, fwereade wrote:
> ...should send an event for every known relation.

Done.

https://codereview.appspot.com/7373046/diff/8001/worker/uniter/filter.go#newcode268
worker/uniter/filter.go:268: // restart the relations watcher
On 2013/02/22 11:41:23, TheMue wrote:
> Maybe too pedantic, but like a correct style here: "Restart the
relations
> watcher.". See the "Send events ..." comment above.

Done.

https://codereview.appspot.com/7373046/

« Back to merge proposal