Code review comment for lp:~dimitern/goamz/vpc-instance-addons

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

https://codereview.appspot.com/60620043/diff/60001/ec2/ec2.go
File ec2/ec2.go (right):

https://codereview.appspot.com/60620043/diff/60001/ec2/ec2.go#newcode204
ec2/ec2.go:204: // NetworkInterfaceSpec encapsulates options for a
single network
Ah, and as we discussed, this type should be something along the lines
of

     RunNetworkInterface

It's an unfortunate name, but I cannot come up with anything better that
is not absurdly long.

For the record, the generic name "NetworkInterfaceSpec" sounds like a
problem because this is actually a set of options that only really make
sense in the specific context of RunInstances. We already have another
bag of data that only really makes sense in the context of
CreateNetworkInterface. If we need one more, will we name it
NetworkInterface..Data?..Stuff?

https://codereview.appspot.com/60620043/

« Back to merge proposal