LGTM.
https://codereview.appspot.com/49930045/diff/100001/ec2/ec2.go File ec2/ec2.go (right):
https://codereview.appspot.com/49930045/diff/100001/ec2/ec2.go#newcode177 ec2/ec2.go:177: return makeParamsWithVersion(action, "2011-12-15") I'd stick "2011-12-15" in a const too. Nice adaptation to allow version passing.
https://codereview.appspot.com/49930045/diff/100001/ec2/ec2t_test.go File ec2/ec2t_test.go (right):
https://codereview.appspot.com/49930045/diff/100001/ec2/ec2t_test.go#newcode627 ec2/ec2t_test.go:627: func (s *ServerTests) deleteGroups(c *C, groups []ec2.SecurityGroup) { This is somewhat ick, but I like that there's enough logging going on so failures that hit the timeout should be clear enough.
https://codereview.appspot.com/49930045/
« Back to merge proposal
LGTM.
https:/ /codereview. appspot. com/49930045/ diff/100001/ ec2/ec2. go
File ec2/ec2.go (right):
https:/ /codereview. appspot. com/49930045/ diff/100001/ ec2/ec2. go#newcode177 ersion( action, "2011-12-15")
ec2/ec2.go:177: return makeParamsWithV
I'd stick "2011-12-15" in a const too. Nice adaptation to allow version
passing.
https:/ /codereview. appspot. com/49930045/ diff/100001/ ec2/ec2t_ test.go
File ec2/ec2t_test.go (right):
https:/ /codereview. appspot. com/49930045/ diff/100001/ ec2/ec2t_ test.go# newcode627 test.go: 627: func (s *ServerTests) deleteGroups(c *C, groups roup) {
ec2/ec2t_
[]ec2.SecurityG
This is somewhat ick, but I like that there's enough logging going on so
failures that hit the timeout should be clear enough.
https:/ /codereview. appspot. com/49930045/