Code review comment for lp:~dimitern/goamz/vpc-api-calls

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+204514_code.launchpad.net,

Message:
Please take a look.

Description:
ec2: Add support for AWS VPCs

Added the following new API calls:
- CreateVpc
- DeleteVpc
- DescribeVpcs
(and the associated types/responses).

These are needed in order to support VPC-related
operations on EC2, which will come in later follow-ups.

Added tests, updated test doubles and tested live on EC2.

https://code.launchpad.net/~dimitern/goamz/vpc-api-calls/+merge/204514

Requires:
https://code.launchpad.net/~dimitern/goamz/lp-1275406-lpcalserversuite-testinstanceinfo/+merge/204469

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/49930045/

Affected files (+404, -13 lines):
   A [revision details]
   M ec2/ec2.go
   M ec2/ec2_test.go
   M ec2/ec2t_test.go
   M ec2/ec2test/server.go
   M ec2/responses_test.go

« Back to merge proposal