Code review comment for lp:~dimitern/goamz/update-aws-api-version-to-latest

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Two comments were already made highlighting the issue of incompatibility, and despite it both of them are approving the change, and no further comments were made about it here. I find that slightly surprising, as it's obvious that the change will break existing code for people relying on it, both inside Canonical and outside. Note also that when you bump an API like this, it is possible that the same operations now have different outcomes, and the fact you had to fix the live tests, per the commit log, seems to indicate that this is happening.

So considering that the juju team is responsible for that package, what is your approach to backwards compatibility, and what's the plan now and for the future?

Also, have you reviewed the change log to consider whether this change might break existing clients due to subtle behavior change in existing operations? Tests will most likely not get all of these cases.

« Back to merge proposal