Code review comment for lp:~dimitern/goamz/subnets-api-calls
Revision history for this message
| Dimiter Naydenov (dimitern) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
*** Submitted:
ec2: Add support for VPC subnets
Added the following new API calls:
- CreateSubnet
- DeleteSubnet
- Subnets
(and related types/responses)
This is the second step on the path to
support VPC networking in goamz, next
APIs for network interfaces will be
added.
Tested live on EC2, and extended the
ec2test package as needed.
Added a deleteVPCs test helpers which
waits until a VPC is no longer in use
and can be deleted, retrying as needed
when running against live EC2 servers.
This is needed to ensure live tests do
no leave stuff behind (I've run all live
tests several times in a row to make sure
it works).
R=rog, gz, niemeyer
CC=
https:/
https:/
File ec2/subnets.go (right):
https:/
ec2/subnets.go:8: // Written by Gustavo Niemeyer
<email address hidden>
On 2014/02/12 13:33:51, niemeyer wrote:
> Please drop this line.
Done.
https:/
ec2/subnets.go:45: // (assuming you want only a single subnet in the
VPC), or a subset of
On 2014/02/12 13:33:51, niemeyer wrote:
> Documentation should be impersonal:
> "assuming a single subnet is wanted"
Done.
https:/
ec2/subnets.go:51: // availZone may be empty, in which case Amazon EC2
selects one for
On 2014/02/12 13:33:51, niemeyer wrote:
> // If availZone is empty, an availability zone is automatically
> // selected.
Done.
https:/
ec2/subnets.go:93: // Subnets describes one or more of your subnets.
Both parameters are
On 2014/02/12 13:33:51, niemeyer wrote:
> // Subnets returns one or more subnets. Both ...
Done.
https:/
File ec2/subnets_test.go (right):
https:/
ec2/subnets_
<email address hidden>
On 2014/02/12 13:33:51, niemeyer wrote:
> Please drop this line.
Done.
https:/