LGTM
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets.go File ec2/subnets.go (right):
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets.go#newcode8 ec2/subnets.go:8: // Written by Gustavo Niemeyer <email address hidden> Please drop this line.
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets.go#newcode45 ec2/subnets.go:45: // (assuming you want only a single subnet in the VPC), or a subset of Documentation should be impersonal:
"assuming a single subnet is wanted"
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets.go#newcode51 ec2/subnets.go:51: // availZone may be empty, in which case Amazon EC2 selects one for // If availZone is empty, an availability zone is automatically // selected.
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets.go#newcode93 ec2/subnets.go:93: // Subnets describes one or more of your subnets. Both parameters are // Subnets returns one or more subnets. Both ...
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets_test.go File ec2/subnets_test.go (right):
https://codereview.appspot.com/54690048/diff/100001/ec2/subnets_test.go#newcode8 ec2/subnets_test.go:8: // Written by Gustavo Niemeyer <email address hidden> Please drop this line.
https://codereview.appspot.com/54690048/
« Back to merge proposal
LGTM
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets. go
File ec2/subnets.go (right):
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets. go#newcode8
ec2/subnets.go:8: // Written by Gustavo Niemeyer
<email address hidden>
Please drop this line.
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets. go#newcode45
ec2/subnets.go:45: // (assuming you want only a single subnet in the
VPC), or a subset of
Documentation should be impersonal:
"assuming a single subnet is wanted"
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets. go#newcode51
ec2/subnets.go:51: // availZone may be empty, in which case Amazon EC2
selects one for
// If availZone is empty, an availability zone is automatically
// selected.
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets. go#newcode93
ec2/subnets.go:93: // Subnets describes one or more of your subnets.
Both parameters are
// Subnets returns one or more subnets. Both ...
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets_ test.go
File ec2/subnets_test.go (right):
https:/ /codereview. appspot. com/54690048/ diff/100001/ ec2/subnets_ test.go# newcode8 test.go: 8: // Written by Gustavo Niemeyer
ec2/subnets_
<email address hidden>
Please drop this line.
https:/ /codereview. appspot. com/54690048/