Code review comment for lp:~dimitern/goamz/subnets-api-calls

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Reviewers: mp+204640_code.launchpad.net,

Message:
Please take a look.

Description:
ec2: Add support for VPC subnets

Added the following new API calls:
- CreateSubnet
- DeleteSubnet
- DescribeSubnets
(and related types/responses)

This is the second step on the path to
support VPC networking in goamz, next
APIs for network interfaces will be
added.

Using AWS API version 2011-12-15.

Tested live on EC2, and extended the
ec2test package as needed.

https://code.launchpad.net/~dimitern/goamz/subnets-api-calls/+merge/204640

Requires:
https://code.launchpad.net/~dimitern/goamz/vpc-api-calls/+merge/204514

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/54690048/

Affected files (+466, -2 lines):
   A [revision details]
   M ec2/ec2test/server.go
   M ec2/responses_test.go
   A ec2/subnets.go
   A ec2/subnets_test.go

« Back to merge proposal