Code review comment for lp:~dimitern/goamz/nic-api-calls
Revision history for this message
| Dimiter Naydenov (dimitern) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Please take a look.
https:/
File ec2/ec2.go (right):
https:/
ec2/ec2.go:635: // CreateSecurityGroup run a CreateSecurityGroup request
in EC2, with
On 2014/02/05 15:17:35, rog wrote:
> s/run/runs/
Done.
https:/
ec2/ec2.go:643: // CreateSecurityG
EC2, associated
On 2014/02/05 15:17:35, rog wrote:
> s/,//
> // If vpcId is empty, this call is equivalent to CreateSecurityG
> ?
Done.
https:/
File ec2/networkinte
https:/
ec2/networkinte
address by setting
On 2014/02/05 15:17:35, rog wrote:
> Why have we got both PrivateIPs and PrivateIPAddress?
> Couldn't we have PrivateIPs only and avoid the question
> of what happens when they're both set?
I tried to stay close to the AWS API, which allows both but with some
conditions. Having PrivateIPAddress and setting just that is a shortcut
to setting PrivateIPs: []ec2.PrivateIP
true}}. But perhaps the slightly more verbose syntax will work well to
hide the API complexity.
https:/
ec2/networkinte
address, EC2 selects one for you
On 2014/02/05 15:17:35, rog wrote:
> // If a private IP address is not specified, EC2 selects
> // one from the subnet range.
Done slightly differently.
https:/
ec2/networkinte
of secondary private IP
On 2014/02/05 15:17:35, rog wrote:
> // When SecondaryPrivat
> // EC2 allocates that number of
> // IP addresses from within the subnet range.
> // The number of IP addresses you
> // can assign to a network interface varies by instance type.
> ?
Done.
https:/
ec2/networkinte
before you can delete it.
On 2014/02/05 15:17:35, rog wrote:
> // DeleteNetworkIn
> // which must have been previously detached.
> ?
Done.
https:/
ec2/networkinte
response to a
On 2014/02/05 15:17:35, rog wrote:
> s/ a/ an/
Done.
https:/