Code review comment for lp:~diegosarmentero/unity8/unity-rates-and-scroll

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

You should use bottomMargin for the keyboard size. [1]

You should also scroll the content when keyboard size changes, so that you're not left with the keyboard obscuring the text field you've just focused.

Also, use skip() instead of commenting out the tests. Same for the AppReviews itself - just make it invisible to reduce diff size and ease the review.

[1] http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-flickable.html#bottomMargin-prop

review: Needs Fixing

« Back to merge proposal