Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/wizard-sizes

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I'm getting all these failures (confirmed they are not present in trunk):

[FAIL]
Traceback (most recent call last):
  File "/home/nessita/canonical/u1/windows-installer/review_wizard-sizes/ubuntuone_installer/gui/qt/tests/test_gui.py", line 421, in test_continue_cancels_cancel
    self.assertEqual(self.ui.isVisible(), True)
twisted.trial.unittest.FailTest: not equal:
a = False
b = True

ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_continue_cancels_cancel
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/home/nessita/canonical/u1/windows-installer/review_wizard-sizes/ubuntuone_installer/gui/qt/tests/test_gui.py", line 175, in test_execute_uninstall_on_licence_cancel
    self.assertTrue(self._called)
twisted.trial.unittest.FailTest: None

ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_execute_uninstall_on_licence_cancel
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/home/nessita/canonical/u1/windows-installer/review_wizard-sizes/ubuntuone_installer/gui/qt/tests/test_gui.py", line 186, in test_execute_uninstall_on_licence_cancel_frozen
    self.assertTrue(self._called)
twisted.trial.unittest.FailTest: None

ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_execute_uninstall_on_licence_cancel_frozen
-------------------------------------------------------------------------------
Ran 125 tests in 1.513s

FAILED (skips=1, failures=3, successes=121)

review: Needs Fixing

« Back to merge proposal