Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/ui-improves

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

* The branch lacks of tests for the new modules local_folders.py and preferences.py.
* Why you removed the LocalFoldersTestCase?
* Also, test for local_folders.py is needed: I understand there was no former tests for this module, so I request just a test for the new functionality added/modified (show_hide_offer and on_add_storage_button_clicked).

- Local Folders Tests are going to be implemented in another branch because they have to be made from scratch (I'm adding that again and leave it as skipped)

* Question, why did you remove this code? set_button_setup_account_property

- This was an old implementation that didn't make the proper validation, now the validation function is working correctly and this code is no longer necessary.

« Back to merge proposal