Ubuntu One Windows Installer

Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/successful-page

successful-page
Merge into trunk

Revision history for this message

Natalia Bidart (nataliabidart) wrote on 2011-11-08:

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1020, in _inlineCallbacks
    result = g.send(result)
  File "/home/nessita/canonical/windows-installer/review_successful-page/ubuntuone_installer/gui/qt/tests/__init__.py", line 204, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/nessita/canonical/windows-installer/review_successful-page/ubuntuone_installer/gui/qt/gui.py", line 431, in __init__
    self.success = SuccessPage(self)
  File "/home/nessita/canonical/windows-installer/review_successful-page/ubuntuone_installer/gui/qt/gui.py", line 278, in __init__
    self.ui.image_label.setPixmap(
exceptions.AttributeError: 'Ui_SuccessPage' object has no attribute 'image_label'

ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_choose_signin_cancel
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_close_callback_can_be_none
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_congratulations_adds_to_autostart
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_continue_cancels_cancel
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_critical
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_critical_in_proper_page
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_current_user_controller_parameters
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_current_user_controller_params
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_current_user_initialize
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_done_calls_custom_close_callback
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_execute_uninstall_on_licence_cancel
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_execute_uninstall_on_licence_cancel_frozen
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_folders_page_next_id
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_folders_page_with_back
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_forgotten_password_controller_error
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_forgotten_password_controller_params
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_initialize_page
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_insert_remove_critical_message
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_license_page_check_connection_error
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_license_page_check_connection_no_button
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_main_window_general_config
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_network_detection_connection_disabled
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_network_detection_connection_disabled_signin
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_network_detection_connection_enabled
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_network_detection_connection_enabled_signin
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_network_detection_retry_fail
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_network_detection_retry_works
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_next_hides_overlay
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_not_start_control_panel_on_cancel
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_overlay_connection_current_user
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_overlay_connection_email_verification
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_overlay_connection_forgotten_password
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_overlay_connection_reset_password
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_overlay_connection_setup_account
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_preferences_cleanup_page
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_preferences_page
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_preferences_page_button_clicked
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_preferences_page_navigation_buttons
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_reset_password_controller_params
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_setup_account_controller_params
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_setup_account_hide_event_enabled_false
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_setup_account_show_event_enabled_false
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_side_widget_state
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_signin_page_check_connection_error
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_1
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_10
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_11
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_12
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_2
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_3
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_4
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_5
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_6
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_7
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_8
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_stage_progression_9
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_start_control_panel
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_user_is_sure_in_last_page
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_with_flag
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_without_flag
ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_wizard_init
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1020, in _inlineCallbacks
    result = g.send(result)
  File "/home/nessita/canonical/windows-installer/review_successful-page/ubuntuone_installer/gui/qt/tests/__init__.py", line 204, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/nessita/canonical/windows-installer/review_successful-page/ubuntuone_installer/gui/qt/gui.py", line 278, in __init__
    self.ui.image_label.setPixmap(
exceptions.AttributeError: 'Ui_SuccessPage' object has no attribute 'image_label'

ubuntuone_installer.gui.qt.tests.test_gui.SuccesPageTestCase.test_after_initialize

review: Needs Fixing

« Back to merge proposal