Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/setup-buttons

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

> self.setup_account.ui.set_up_button.clicked.connect(
> self.overlay.show)

Because this button doesn't exists anymore, and that signal is being connected on initializePage on SetupAccountPage

> * If you're patching self.patch(self.ui, 'wizard', FakeWizard) in every test
> method in SetupAccountTestCase, please add that to the setUp method to avoid
> duplication.

I don't need that in every tests, just in the ones i added, otherwise if i patch the wizard in the setup cause the other tests to fail.

« Back to merge proposal