Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/network-detect

Revision history for this message
Alejandro J. Cura (alecu) wrote :

The try: except: removed in the previous-to-last commit should not be removed, because if networkstate.is_machine_connected fails before returning a deferred, or if that deferred errbacks, then we should treat this as if the connection is present.

review: Needs Fixing

« Back to merge proposal