Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/network-detect

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

The is an error in a test:

===============================================================================
[FAIL]
Traceback (most recent call last):
  File "E:\windows-installer\review_network-detect\ubuntuone_installer\gui\qt\te
sts\test_gui.py", line 196, in test_license_page_check_connection_error
    self.assertEqual(self.ui.form_errors_label.text(), 'Error...')
twisted.trial.unittest.FailTest: not equal:
a = PyQt4.QtCore.QString(u'The network state can not be detected.')
b = 'Error...'

ubuntuone_installer.gui.qt.tests.test_gui.MainWindowTestCase.test_license_page_c
heck_connection_error
-------------------------------------------------------------------------------

Please run the tests *every single time* before pushing a change, even if it's just a string change ;-). Thanks!

review: Needs Fixing

« Back to merge proposal