Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/network-detect

Revision history for this message
Alejandro J. Cura (alecu) wrote :

This branch is looking lovely, thanks for working on it.

One issue:
138 + except Exception, reason:
...
140 + self.critical(reason.message, self.network_page)

I don't think that showing in the UI the exception message is the right thing
I think we should have a generic/custom error message that's translatable in the U1-win-installer code itself; something like "Cannot get network state" and log the exact reason.

review: Needs Fixing

« Back to merge proposal