Ubuntu One Windows Installer

Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/network-detect

  1. network-detect
  2. Merge into trunk
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

- The new TestCase added in ubuntuone_installer/gui/tests/__init__.py is duplicated from ubuntuone_installer/tests/__init__.py, please use that instead.

- As far as I see, there are no test for the new module ubuntuone_installer/gui/qt/network_detection.py. There should be a new test file called ubuntuone_installer/gui/qt/tests/test_network_detection.py that tests that new module.

review: Needs Fixing

« Back to merge proposal