Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/network-detect

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Running u1lint directly on this branch I'm getting these:

== Python Lint Notices ==

ubuntuone_installer/gui/qt/gui.py:
    200: [W0212, LicensePage.check_connection] Access to a protected member _next_id of a client class

ubuntuone_installer/gui/qt/tests/__init__.py:
    185: [C0103, FakeWizardButtonStyle.__init__] Invalid name "customButtonClicked" (should match [a-z_][a-z0-9_]{1,30}$)

ubuntuone_installer/gui/qt/tests/test_gui.py:
    154: [W0622, MainWindowTestCase.test_network_detection_connection_enabled] Redefining built-in 'id'
    166: [W0622, MainWindowTestCase.test_network_detection_connection_disabled] Redefining built-in 'id'
    178: [W0622, MainWindowTestCase.test_license_page_check_connection_no_button] Redefining built-in 'id'
    194: [W0622, MainWindowTestCase.test_license_page_check_connection_error] Redefining built-in 'id'
    216: [W0212, MainWindowTestCase.test_check_connection_with_connection] Access to a protected member _next_id of a client class
    225: [W0212, MainWindowTestCase.test_check_connection_with_no_connection] Access to a protected member _next_id of a client class
    237: [W0212, MainWindowTestCase.test_check_connection_with_exception] Access to a protected member _next_id of a client class

« Back to merge proposal