Merge lp:~diegosarmentero/ubuntuone-windows-installer/mac-env into lp:ubuntuone-windows-installer

Proposed by Diego Sarmentero
Status: Merged
Approved by: Diego Sarmentero
Approved revision: 117
Merged at revision: 113
Proposed branch: lp:~diegosarmentero/ubuntuone-windows-installer/mac-env
Merge into: lp:ubuntuone-windows-installer
Diff against target: 24 lines (+20/-0)
1 file modified
scripts/devsetup/env-mac (+20/-0)
To merge this branch: bzr merge lp:~diegosarmentero/ubuntuone-windows-installer/mac-env
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
dobey (community) Approve
Review via email: mp+103525@code.launchpad.net

Commit message

- Adding script to setup the development enviroment vars in Mac OS

To post a comment you must log in.
115. By Diego Sarmentero

updating environment setup script

Revision history for this message
dobey (dobey) wrote :

This should not inject things into ~/.profile. It should modify the current environment when it is run.
Also, could you change the name of the $CURRENT variable, to be $CWD or $PWD, so it's easier to read the script? The generic $CURRENT name means I have to keep looking up in the file to see what it actually is. But $CWD or $PWD would be much more descriptive (and even shorter). :)

review: Needs Fixing
116. By Diego Sarmentero

avoid modifying .profile

117. By Diego Sarmentero

removing python_u1

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'scripts/devsetup/env-mac'
--- scripts/devsetup/env-mac 1970-01-01 00:00:00 +0000
+++ scripts/devsetup/env-mac 2012-04-27 15:57:21 +0000
@@ -0,0 +1,20 @@
1#!/bin/bash
2
3CURRENT_DIR=`pwd`
4echo "Adding buildout bin path to the system path"
5PATH=`pwd`/bin:$PATH
6
7echo "Adding u1trial to env-vars"
8export u1trial="`find $CURRENT_DIR -type f -name u1trial`"
9
10echo "Adding u1lint to env-vars"
11export u1lint="`find $CURRENT_DIR -type f -name u1lint`"
12
13if [ ! -f `pwd`/bin/pylint ]; then
14 echo "Adding pylint script to the bin folder"
15 PYLINT_PATH="`find $CURRENT_DIR -type f -name pylint`"
16 PYLINT_SCRIPT="$CURRENT_DIR/bin/pylint"
17 echo "#!/usr/bin/env sh" > $PYLINT_SCRIPT
18 echo "python $PYLINT_PATH "'$@' >> $PYLINT_SCRIPT
19 chmod +x $PYLINT_SCRIPT
20fi

Subscribers

People subscribed via source and target branches