Merge lp:~diegosarmentero/ubuntuone-windows-installer/mac-env into lp:ubuntuone-windows-installer
Proposed by
Diego Sarmentero
on 2012-04-25
| Status: | Merged |
|---|---|
| Approved by: | Diego Sarmentero on 2012-05-01 |
| Approved revision: | 117 |
| Merged at revision: | 113 |
| Proposed branch: | lp:~diegosarmentero/ubuntuone-windows-installer/mac-env |
| Merge into: | lp:ubuntuone-windows-installer |
| Diff against target: |
24 lines (+20/-0) 1 file modified
scripts/devsetup/env-mac (+20/-0) |
| To merge this branch: | bzr merge lp:~diegosarmentero/ubuntuone-windows-installer/mac-env |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Manuel de la Peña (community) | Approve on 2012-05-01 | ||
| dobey (community) | 2012-04-25 | Approve on 2012-04-27 | |
|
Review via email:
|
|||
Commit Message
- Adding script to setup the development enviroment vars in Mac OS
To post a comment you must log in.
lp:~diegosarmentero/ubuntuone-windows-installer/mac-env
updated
on 2012-04-27
- 115. By Diego Sarmentero on 2012-04-27
-
updating environment setup script
lp:~diegosarmentero/ubuntuone-windows-installer/mac-env
updated
on 2012-04-27
- 116. By Diego Sarmentero on 2012-04-27
-
avoid modifying .profile
- 117. By Diego Sarmentero on 2012-04-27
-
removing python_u1
review:
Approve
review:
Approve

This should not inject things into ~/.profile. It should modify the current environment when it is run.
Also, could you change the name of the $CURRENT variable, to be $CWD or $PWD, so it's easier to read the script? The generic $CURRENT name means I have to keep looking up in the file to see what it actually is. But $CWD or $PWD would be much more descriptive (and even shorter). :)