Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/close-on-license

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

> Why you're asserting this?
>
> self.assertFalse(hasattr(self, '_called'))
>
> I would expect the test to assert self.assertFalse(self._called), I can't see
> how the _called attr disappears.

I'm testing that this function is not being called really, and BaseTestCase create self._called when that function is executed, so i'm testing that the attribute doesn't exists.

« Back to merge proposal