Code review comment for lp:~diegosarmentero/ubuntuone-windows-installer/close-on-license

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* This does not work:

self.addCleanup(setattr(sys, 'frozen', frozen))

addCleanup receives a function, so it should be:

self.addCleanup(setattr, sys, 'frozen', frozen)

* This self.addCleanup(lambda: delattr(sys, "frozen")) can be improved to self.addCleanup(delattr, sys, "frozen").

review: Needs Fixing

« Back to merge proposal