Code review comment for lp:~diegosarmentero/ubuntuone-control-panel/new-share-design

Revision history for this message
dobey (dobey) wrote :

21 + <string>Search and Share files</string>
281 +SEARCH_FILES = _('Search and Share files')

These need to be sentence case ('share' should be lowercase). http://developer.gnome.org/hig-book/stable/design-text-labels.html.en#layout-capitalization

274 +PUBLISH_FILE = _('Publish file')
275 +PUBLISH_THESE_FILES = _('Select a file to publish:"')

Presumably we should not use the term 'publish' here.

684 + publicfiles = [
685 + {'path': '/home/file1', 'public_url': 'http:ubuntuone.com/asd123'},
686 + {'path': '/home/file2', 'public_url': 'http:ubuntuone.com/qwe456'},
687 + ]

744 + results = ['/home/file1', '/home/file2']

934 + items = [
935 + '/home/tester/file1',
936 + '/home/tester/file2',
937 + '/home/tester/file3',
938 + ]

Should these 3 sets of filenames in tests not be created with os.path.join() instead, for cross-platform happiness? Should it also not use the $HOME (the user_home from dirspec), here?

review: Needs Fixing

« Back to merge proposal