Code review comment for lp:~diegosarmentero/ubuntuone-control-panel/new-share-design

Revision history for this message
MichaƂ Karnicki (karni) wrote :

Hardcoded value at
386 + self.ui.stacked_widget.setCurrentIndex(2)
could be replaced by a constant, that tells its meaning.

Hardcoded values at
515 + increment = 2 if current == 0 else 1
tell me little about what they mean. Unless this is obvious for Qt developers, fix with constants.

Quite a few constants in the tests make me think they are very sensitive to test data set changes.

Other than that, looks good.

review: Approve

« Back to merge proposal