Code review comment for lp:~diegosarmentero/ubuntuone-client/ubuntuone-client-syncc

The code on this branch looks fine, but testing this branch IRL shows a very noticeable regression:
Syndaemon running from trunk uses 0% cpu while idle. This branch uses 1% cpu on my machine (+1% cpu for the sync indicator processes), due to the constant updating of the menu.

I think we should both reduce the time between updates for this branch, and create a new bug, and try to come up with a less resource intensive approach, like having the status aggregator code calling some callback in this module whenever there's transfer progress (and even so, no more often than every two or three seconds).

---

Small issue: all occurrences similar to:

213 + def fake_open(url):
214 + data.append(url)
215 +
216 + self.patch(linux.webbrowser, "open", fake_open)

Can be replaced with just this line:

213 + self.patch(linux.webbrowser, "open", data.append)