Code review comment for lp:~diegosarmentero/ubuntuone-client/search-filter

Revision history for this message
Mike McCracken (mikemc) wrote :

I've changed my mind.

For reference: I'm OK with matching fuzzy things, and I was mostly concerned with the order in which they appear, I wanted to be sure the least-surprising match showed up first.

However the only example I found where that might happen was if we have a search pattern with a space, and the files list has a pattern with no space that matches that pattern because of our fuzzy changes. In this case, though, when we sort the matching paths at the end of get_paths_by_pattern, the paths with spaces are sorted first anyway.

So even though using multiple regexes to control the order of matches is only a little slower in real terms, I can't think of a case in which it's necessary.

review: Approve

« Back to merge proposal