Code review comment for lp:~diegosarmentero/ubuntuone-client/fix-dummy

Revision history for this message
dobey (dobey) wrote :

Please chain the __init__ with super here properly so that object.__init__() is called, as well as on the UbuntuOneSyncMenuLinux class.

Also, please use assertNotRaises() to test instantiation of the object is working. To test that start_timer works properly, please add a second test to this test case which creates a dummy object, and then check that the start_timer attribute has a "__call__" attribute itself.

review: Needs Fixing

« Back to merge proposal