Merge lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable into lp:ubuntuone-client/stable-3-0

Proposed by Diego Sarmentero
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable
Merge into: lp:ubuntuone-client/stable-3-0
Diff against target: 145 lines (+63/-47)
2 files modified
ubuntuone/status/aggregator.py (+8/-0)
ubuntuone/syncdaemon/main.py (+55/-47)
To merge this branch: bzr merge lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+216181@code.launchpad.net

Commit message

- Show a message when the client is started indicating that the service will be suspended on June 1st.
- After June 1st, don't contact the server.

Description of the change

Farewell Ubuntu One File Service

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (18.4 KiB)

The attempt to merge lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable into lp:ubuntuone-client/stable-3-0 failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.68
checking for automake >= 1.10...
  testing automake-1.11... found 1.11.3
checking for libtool >= 1.5...
  testing libtoolize... found 2.4.2
checking for intltool >= 0.30...
  testing intltoolize... found 0.50.2
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.26
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.18
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure --enable-gtk-doc --enable-debug ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell und...

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected because is more than 500 days old, and did not have any activity recorded. Change status again if this MP is still current, and please ping someone for review and landing.
Thanks!

Unmerged revisions

1198. By Diego Sarmentero

calling show farewell message function

1197. By Diego Sarmentero

- Show a message when the client is started indicating that the service will be suspended on June 1st.
- After June 1st, don't contact the server.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/status/aggregator.py'
--- ubuntuone/status/aggregator.py 2012-04-09 20:07:05 +0000
+++ ubuntuone/status/aggregator.py 2014-04-16 18:20:57 +0000
@@ -49,6 +49,8 @@
49Q_ = lambda string: gettext.dgettext(GETTEXT_PACKAGE, string)49Q_ = lambda string: gettext.dgettext(GETTEXT_PACKAGE, string)
5050
51UBUNTUONE_TITLE = Q_("Ubuntu One")51UBUNTUONE_TITLE = Q_("Ubuntu One")
52UBUNTUONE_END = Q_("Ubuntu One file services will be "
53 "shutting down on June 1st, 2014.\nThanks for your support.")
52NEW_UDFS_SENDER = Q_("New cloud folder(s) available")54NEW_UDFS_SENDER = Q_("New cloud folder(s) available")
53FINAL_COMPLETED = Q_("File synchronization completed.")55FINAL_COMPLETED = Q_("File synchronization completed.")
5456
@@ -805,6 +807,12 @@
805 self.notification = self.aggregator.get_notification()807 self.notification = self.aggregator.get_notification()
806 self.messaging = Messaging()808 self.messaging = Messaging()
807 self.quota_timer = None809 self.quota_timer = None
810 self.farewell_ubuntuone_sync()
811
812 def farewell_ubuntuone_sync(self):
813 """Show notification about the upcoming end of UbuntuOne sync."""
814 self.notification.send_notification(
815 UBUNTUONE_TITLE, UBUNTUONE_END)
808816
809 def file_published(self, public_url):817 def file_published(self, public_url):
810 """A file was published."""818 """A file was published."""
811819
=== modified file 'ubuntuone/syncdaemon/main.py'
--- ubuntuone/syncdaemon/main.py 2012-04-09 20:08:42 +0000
+++ ubuntuone/syncdaemon/main.py 2014-04-16 18:20:57 +0000
@@ -31,6 +31,7 @@
31import logging31import logging
32import os32import os
33import sys33import sys
34import datetime
3435
35from twisted.internet import defer, reactor, task36from twisted.internet import defer, reactor, task
3637
@@ -106,53 +107,60 @@
106 if not throttling_enabled:107 if not throttling_enabled:
107 throttling_enabled = user_config.get_throttling()108 throttling_enabled = user_config.get_throttling()
108109
109 self.logger.info("Starting Ubuntu One client version %s",110 end_date = datetime.date(2014, 6, 1)
110 clientdefs.VERSION)111 if datetime.date.today() < end_date:
111 self.logger.info("Using %r as root dir", self.root_dir)112 self.logger.info("Starting Ubuntu One client version %s",
112 self.logger.info("Using %r as data dir", self.data_dir)113 clientdefs.VERSION)
113 self.logger.info("Using %r as shares root dir", self.shares_dir)114 self.logger.info("Using %r as root dir", self.root_dir)
114 self.db = tritcask.Tritcask(native_path(tritcask_dir))115 self.logger.info("Using %r as data dir", self.data_dir)
115 self.vm = volume_manager.VolumeManager(self)116 self.logger.info("Using %r as shares root dir", self.shares_dir)
116 self.fs = filesystem_manager.FileSystemManager(117 self.db = tritcask.Tritcask(native_path(tritcask_dir))
117 data_dir, partials_dir, self.vm, self.db)118 self.vm = volume_manager.VolumeManager(self)
118 self.event_q = event_queue.EventQueue(self.fs, ignore_files)119 self.fs = filesystem_manager.FileSystemManager(
119 self.fs.register_eq(self.event_q)120 data_dir, partials_dir, self.vm, self.db)
120121 self.event_q = event_queue.EventQueue(self.fs, ignore_files)
121 # subscribe VM to EQ, to be unsubscribed in shutdown122 self.fs.register_eq(self.event_q)
122 self.event_q.subscribe(self.vm)123
123 self.vm.init_root()124 # subscribe VM to EQ, to be unsubscribed in shutdown
124125 self.event_q.subscribe(self.vm)
125 # we don't have the oauth tokens yet, we 'll get them later126 self.vm.init_root()
126 self.action_q = action_queue.ActionQueue(self.event_q, self,127
127 host, port,128 # we don't have the oauth tokens yet, we 'll get them later
128 dns_srv, ssl,129 self.action_q = action_queue.ActionQueue(self.event_q, self,
129 disable_ssl_verify,130 host, port,
130 read_limit, write_limit,131 dns_srv, ssl,
131 throttling_enabled)132 disable_ssl_verify,
132 self.hash_q = hash_queue.HashQueue(self.event_q)133 read_limit, write_limit,
133 events_nanny.DownloadFinishedNanny(self.fs, self.event_q, self.hash_q)134 throttling_enabled)
134135 self.hash_q = hash_queue.HashQueue(self.event_q)
135 # call StateManager after having AQ136 events_nanny.DownloadFinishedNanny(self.fs, self.event_q,
136 self.state_manager = StateManager(self, handshake_timeout)137 self.hash_q)
137138
138 self.sync = sync.Sync(self)139 # call StateManager after having AQ
139 self.lr = local_rescan.LocalRescan(self.vm, self.fs,140 self.state_manager = StateManager(self, handshake_timeout)
140 self.event_q, self.action_q)141
141142 self.sync = sync.Sync(self)
142 self.external = SyncdaemonService(main=self,143 self.lr = local_rescan.LocalRescan(self.vm, self.fs,
143 send_events=broadcast_events)144 self.event_q, self.action_q)
144 self.external.oauth_credentials = oauth_credentials145
145 if user_config.get_autoconnect():146 self.external = SyncdaemonService(main=self,
146 self.external.connect(autoconnecting=True)147 send_events=broadcast_events)
147148 self.external.oauth_credentials = oauth_credentials
148 self.eventlog_listener = None149 if user_config.get_autoconnect():
149 self.start_event_logger()150 self.external.connect(autoconnecting=True)
150151
151 self.status_listener = None152 self.eventlog_listener = None
152 self.start_status_listener()153 self.start_event_logger()
153154
154 self.mark = task.LoopingCall(self.log_mark)155 self.status_listener = None
155 self.mark.start(mark_interval)156 self.start_status_listener()
157
158 self.mark = task.LoopingCall(self.log_mark)
159 self.mark.start(mark_interval)
160 else:
161 if reactor.running:
162 reactor.stop()
163 sys.exit(0)
156164
157 def start_event_logger(self):165 def start_event_logger(self):
158 """Start the event logger if it's available for this platform."""166 """Start the event logger if it's available for this platform."""

Subscribers

People subscribed via source and target branches