Merge lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable into lp:ubuntuone-client/stable-3-0

Proposed by Diego Sarmentero
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable
Merge into: lp:ubuntuone-client/stable-3-0
Diff against target: 145 lines (+63/-47)
2 files modified
ubuntuone/status/aggregator.py (+8/-0)
ubuntuone/syncdaemon/main.py (+55/-47)
To merge this branch: bzr merge lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+216181@code.launchpad.net

Commit message

- Show a message when the client is started indicating that the service will be suspended on June 1st.
- After June 1st, don't contact the server.

Description of the change

Farewell Ubuntu One File Service

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (18.4 KiB)

The attempt to merge lp:~diegosarmentero/ubuntuone-client/farewell-u1-stable into lp:ubuntuone-client/stable-3-0 failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.68
checking for automake >= 1.10...
  testing automake-1.11... found 1.11.3
checking for libtool >= 1.5...
  testing libtoolize... found 2.4.2
checking for intltool >= 0.30...
  testing intltoolize... found 0.50.2
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.26
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.18
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure --enable-gtk-doc --enable-debug ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell und...

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected because is more than 500 days old, and did not have any activity recorded. Change status again if this MP is still current, and please ping someone for review and landing.
Thanks!

Unmerged revisions

1198. By Diego Sarmentero

calling show farewell message function

1197. By Diego Sarmentero

- Show a message when the client is started indicating that the service will be suspended on June 1st.
- After June 1st, don't contact the server.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/status/aggregator.py'
2--- ubuntuone/status/aggregator.py 2012-04-09 20:07:05 +0000
3+++ ubuntuone/status/aggregator.py 2014-04-16 18:20:57 +0000
4@@ -49,6 +49,8 @@
5 Q_ = lambda string: gettext.dgettext(GETTEXT_PACKAGE, string)
6
7 UBUNTUONE_TITLE = Q_("Ubuntu One")
8+UBUNTUONE_END = Q_("Ubuntu One file services will be "
9+ "shutting down on June 1st, 2014.\nThanks for your support.")
10 NEW_UDFS_SENDER = Q_("New cloud folder(s) available")
11 FINAL_COMPLETED = Q_("File synchronization completed.")
12
13@@ -805,6 +807,12 @@
14 self.notification = self.aggregator.get_notification()
15 self.messaging = Messaging()
16 self.quota_timer = None
17+ self.farewell_ubuntuone_sync()
18+
19+ def farewell_ubuntuone_sync(self):
20+ """Show notification about the upcoming end of UbuntuOne sync."""
21+ self.notification.send_notification(
22+ UBUNTUONE_TITLE, UBUNTUONE_END)
23
24 def file_published(self, public_url):
25 """A file was published."""
26
27=== modified file 'ubuntuone/syncdaemon/main.py'
28--- ubuntuone/syncdaemon/main.py 2012-04-09 20:08:42 +0000
29+++ ubuntuone/syncdaemon/main.py 2014-04-16 18:20:57 +0000
30@@ -31,6 +31,7 @@
31 import logging
32 import os
33 import sys
34+import datetime
35
36 from twisted.internet import defer, reactor, task
37
38@@ -106,53 +107,60 @@
39 if not throttling_enabled:
40 throttling_enabled = user_config.get_throttling()
41
42- self.logger.info("Starting Ubuntu One client version %s",
43- clientdefs.VERSION)
44- self.logger.info("Using %r as root dir", self.root_dir)
45- self.logger.info("Using %r as data dir", self.data_dir)
46- self.logger.info("Using %r as shares root dir", self.shares_dir)
47- self.db = tritcask.Tritcask(native_path(tritcask_dir))
48- self.vm = volume_manager.VolumeManager(self)
49- self.fs = filesystem_manager.FileSystemManager(
50- data_dir, partials_dir, self.vm, self.db)
51- self.event_q = event_queue.EventQueue(self.fs, ignore_files)
52- self.fs.register_eq(self.event_q)
53-
54- # subscribe VM to EQ, to be unsubscribed in shutdown
55- self.event_q.subscribe(self.vm)
56- self.vm.init_root()
57-
58- # we don't have the oauth tokens yet, we 'll get them later
59- self.action_q = action_queue.ActionQueue(self.event_q, self,
60- host, port,
61- dns_srv, ssl,
62- disable_ssl_verify,
63- read_limit, write_limit,
64- throttling_enabled)
65- self.hash_q = hash_queue.HashQueue(self.event_q)
66- events_nanny.DownloadFinishedNanny(self.fs, self.event_q, self.hash_q)
67-
68- # call StateManager after having AQ
69- self.state_manager = StateManager(self, handshake_timeout)
70-
71- self.sync = sync.Sync(self)
72- self.lr = local_rescan.LocalRescan(self.vm, self.fs,
73- self.event_q, self.action_q)
74-
75- self.external = SyncdaemonService(main=self,
76- send_events=broadcast_events)
77- self.external.oauth_credentials = oauth_credentials
78- if user_config.get_autoconnect():
79- self.external.connect(autoconnecting=True)
80-
81- self.eventlog_listener = None
82- self.start_event_logger()
83-
84- self.status_listener = None
85- self.start_status_listener()
86-
87- self.mark = task.LoopingCall(self.log_mark)
88- self.mark.start(mark_interval)
89+ end_date = datetime.date(2014, 6, 1)
90+ if datetime.date.today() < end_date:
91+ self.logger.info("Starting Ubuntu One client version %s",
92+ clientdefs.VERSION)
93+ self.logger.info("Using %r as root dir", self.root_dir)
94+ self.logger.info("Using %r as data dir", self.data_dir)
95+ self.logger.info("Using %r as shares root dir", self.shares_dir)
96+ self.db = tritcask.Tritcask(native_path(tritcask_dir))
97+ self.vm = volume_manager.VolumeManager(self)
98+ self.fs = filesystem_manager.FileSystemManager(
99+ data_dir, partials_dir, self.vm, self.db)
100+ self.event_q = event_queue.EventQueue(self.fs, ignore_files)
101+ self.fs.register_eq(self.event_q)
102+
103+ # subscribe VM to EQ, to be unsubscribed in shutdown
104+ self.event_q.subscribe(self.vm)
105+ self.vm.init_root()
106+
107+ # we don't have the oauth tokens yet, we 'll get them later
108+ self.action_q = action_queue.ActionQueue(self.event_q, self,
109+ host, port,
110+ dns_srv, ssl,
111+ disable_ssl_verify,
112+ read_limit, write_limit,
113+ throttling_enabled)
114+ self.hash_q = hash_queue.HashQueue(self.event_q)
115+ events_nanny.DownloadFinishedNanny(self.fs, self.event_q,
116+ self.hash_q)
117+
118+ # call StateManager after having AQ
119+ self.state_manager = StateManager(self, handshake_timeout)
120+
121+ self.sync = sync.Sync(self)
122+ self.lr = local_rescan.LocalRescan(self.vm, self.fs,
123+ self.event_q, self.action_q)
124+
125+ self.external = SyncdaemonService(main=self,
126+ send_events=broadcast_events)
127+ self.external.oauth_credentials = oauth_credentials
128+ if user_config.get_autoconnect():
129+ self.external.connect(autoconnecting=True)
130+
131+ self.eventlog_listener = None
132+ self.start_event_logger()
133+
134+ self.status_listener = None
135+ self.start_status_listener()
136+
137+ self.mark = task.LoopingCall(self.log_mark)
138+ self.mark.start(mark_interval)
139+ else:
140+ if reactor.running:
141+ reactor.stop()
142+ sys.exit(0)
143
144 def start_event_logger(self):
145 """Start the event logger if it's available for this platform."""

Subscribers

People subscribed via source and target branches