Code review comment for lp:~diegosarmentero/ubuntuone-client/darwin2-fsevents

Revision history for this message
Alejandro J. Cura (alecu) wrote :

This comment is *Very* specific to windows:

        # On windows there is no need to add the watches to the ancestors
        # so we will always return true. The reason for this is that the
        # handles that we open stop the user from renaming the ancestors of
        # the UDF, for a user to do that he has to unsync the udf first

This too:
    For Windows:
    Also, they must not be literal paths, that is the \\?\ prefix should not be
    in the path.

Both should be in windows.py.

review: Needs Fixing

« Back to merge proposal