Here are some more comments that I didn't think of on my first review:
----
This first decorator makes sense; I'm not sure about the other two.
Anyway, the string in the first one is wrong:
+skip_if_darwin_and_uses_metadata_older_than_5 = \
+ skipIfOS('darwin',
+ 'In windows there is no need to migrate metadata older than v5.')
Do we know of any Read/Only issue on darwin to justify this decorator?
+skip_if_darwin_and_uses_readonly = \
+ skipIfOS('darwin', 'Can not test RO shares until bug #820350 is resolved.')
We may have some missing or out of order events in darwin, but we surely need to apply this decorator to the specific tests that fail with darwin, and we have to make sure we don't do a blanket decoration of the same test cases than in windows. In any case, we need a new bug with the darwin specifics.
+skip_if_darwin_missing_fs_event = \
+ skipIfOS('darwin', 'Fails due to missing/out of order FS events, '
+ 'see bug #820598.')
Here are some more comments that I didn't think of on my first review:
----
This first decorator makes sense; I'm not sure about the other two.
Anyway, the string in the first one is wrong:
+skip_if_ darwin_ and_uses_ metadata_ older_than_ 5 = \
+ skipIfOS('darwin',
+ 'In windows there is no need to migrate metadata older than v5.')
Do we know of any Read/Only issue on darwin to justify this decorator?
+skip_if_ darwin_ and_uses_ readonly = \
+ skipIfOS('darwin', 'Can not test RO shares until bug #820350 is resolved.')
We may have some missing or out of order events in darwin, but we surely need to apply this decorator to the specific tests that fail with darwin, and we have to make sure we don't do a blanket decoration of the same test cases than in windows. In any case, we need a new bug with the darwin specifics.
+skip_if_ darwin_ missing_ fs_event = \
+ skipIfOS('darwin', 'Fails due to missing/out of order FS events, '
+ 'see bug #820598.')