Code review comment for lp:~diegosarmentero/ubuntu-system-settings/click-updates

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that builds fine and I was able to test, some comments from a first round of user testing (didn't review the changes yet, that's quite some code to review):

- could you made the downloads a bit slower, so it let time to interact with the UI/pause the download, etc

- the dropping letter is displayed as "500000kb", shouldn't it adapt its units and displays "0.5Gb" instead?

- if you start with some clicks update and a system update, you get a list of 2 clicks and no indication it's checking for the system image status, you should display a spinner while the checking is happening (maybe only displays the list when you get results from both system and click updates)

- clicking the "install 3 updates" triggers the update, clicks are done before the system one ... the button doesn't change though, that's a bit confusing: 2 installed, 1 downloading and it still states "Install 3 updates", could you check with design if we could do better?

- if you do press the "install 3 updates"/"pause all" button a few time you easily get dbus errors displayed over the "installed" for the already upgraded clicks

- once the download are done, if have a system update and click on "not now", you get back to the UI. If you click on the "download 3 updates" button then you get the "installing" screen

I'm going to try to review the code early next week (if others want to help reviewing that would be welcome)

review: Needs Fixing

« Back to merge proposal