> * You have my approve, but please before merging remove the following > tearDowns: > > @defer.inlineCallbacks > def tearDown(self): > """Clean up.""" > yield super(BasicTestCase, self).setUp() > self._called = False > > @defer.inlineCallbacks > def tearDown(self): > """Clean up.""" > self.entry = None > yield super(LabeledEntryTestCase, self).tearDown() > > * Also, this setUp is undeeded: > > @defer.inlineCallbacks > def setUp(self): > """Set up.""" > yield super(CredentialsManagementClearTestCase, self).setUp() > > * No need to add docstring for setUp or tearDown. > > * Please remove the addings: > > self.addCleanup(self.connector.disconnect) > self.addCleanup(self.listener.stopListening)
Fixed
« Back to merge proposal
> * You have my approve, but please before merging remove the following inlineCallbacks Case, self).setUp() inlineCallbacks tryTestCase, self).tearDown() inlineCallbacks lsManagementCle arTestCase, self).setUp() (self.connector .disconnect) (self.listener. stopListening)
> tearDowns:
>
> @defer.
> def tearDown(self):
> """Clean up."""
> yield super(BasicTest
> self._called = False
>
> @defer.
> def tearDown(self):
> """Clean up."""
> self.entry = None
> yield super(LabeledEn
>
> * Also, this setUp is undeeded:
>
> @defer.
> def setUp(self):
> """Set up."""
> yield super(Credentia
>
> * No need to add docstring for setUp or tearDown.
>
> * Please remove the addings:
>
> self.addCleanup
> self.addCleanup
Fixed