Code review comment for lp:~diegosarmentero/ubuntu-sso-client/tests-broken

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* You have my approve, but please before merging remove the following tearDowns:

    @defer.inlineCallbacks
    def tearDown(self):
        """Clean up."""
        yield super(BasicTestCase, self).setUp()
        self._called = False

    @defer.inlineCallbacks
    def tearDown(self):
        """Clean up."""
        self.entry = None
        yield super(LabeledEntryTestCase, self).tearDown()

* Also, this setUp is undeeded:

    @defer.inlineCallbacks
    def setUp(self):
        """Set up."""
        yield super(CredentialsManagementClearTestCase, self).setUp()

* No need to add docstring for setUp or tearDown.

* Please remove the addings:

        self.addCleanup(self.connector.disconnect)
        self.addCleanup(self.listener.stopListening)

review: Needs Fixing

« Back to merge proposal