Ubuntu Single Sign On Client

Code review comment for lp:~diegosarmentero/ubuntu-sso-client/show-errors

  1. show-errors
  2. Merge into trunk
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Branch looks good!

* One tiny note: in current_user_sign_in_page.py, cleanupPage should not call self.hide_error() but super() instead.

* Instead of using assertTrue(foo >= bar), can you please ise assertGreaterEqual?

* Can you please restore the removed empty line in ubuntu_sso_wizard.py?

Thanks!

review: Needs Fixing

« Back to merge proposal