> Looks good, but the following:
>
> except Exception, reason:
> message = 'There was a problem trying to setup the page %r' % self
> self.show_error(message)
> log = message + ', error: %r' % reason
> logger.error(log)
> self.setEnabled(False)
>
> should be:
>
> except:
> message = 'There was a problem trying to setup the page %r' % self
> self.show_error(message)
> logger.exception(message)
> self.setEnabled(False)
>
> since logger.exception already adds the traceback when called in an except
> block.
> Looks good, but the following: error(message) (False) error(message) exception( message) (False)
>
> except Exception, reason:
> message = 'There was a problem trying to setup the page %r' % self
> self.show_
> log = message + ', error: %r' % reason
> logger.error(log)
> self.setEnabled
>
> should be:
>
> except:
> message = 'There was a problem trying to setup the page %r' % self
> self.show_
> logger.
> self.setEnabled
>
> since logger.exception already adds the traceback when called in an except
> block.
Done