Code review comment for lp:~diegosarmentero/pay-ui/error-page

Revision history for this message
Ted Gould (ted) wrote :

I think that hideLoading() needs to get pulled out of the if statement.

I think it would perhaps be better if we could instantiate the three(?) error dialogs as different objects instead of having the function. That way their strings end up in the same object together and we don't end up duplicating them in the different functions. I was thinking something like "PopupUtils.open(AuthErrorDialog)"

review: Needs Fixing

« Back to merge proposal