Code review comment for lp:~diegosarmentero/clickmanager-plugin/sign-url

Revision history for this message
dobey (dobey) wrote :

I'm abstaining for now, because this really should be 2 separate branches, one which adds the ClickPlugin namespace changes, and another which depends on that one, which adds the URL signing bits. I don't want to block this too long, given our current time frame, but I do want to state such changes should be split into separate branches when they are this invasive. So I am choosing to Abstain rather than vote Needs Fixing.

« Back to merge proposal