Code review comment for lp:~didrocks/unity-lens-applications/aboutconfig

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I agree that it could be nice with an about: namespace that can trigger certain built in actions.

However, before I merge this i'd rather see a more generic implementation where we can easily add/remove stuff under about:. Having a specific hack only for about:config seems well... a hack :-)

Fx. like adding a

private class AboutEntry {
  public string name;
  public string exec;
  public Icon icon;
}

Store them in a list or map and then in get_icon_uri_and_mimetype() check all registered AboutEntries or something...

review: Needs Fixing

« Back to merge proposal