Merge lp:~didrocks/ubiquity/telemetry-adjustements into lp:ubiquity

[Didier Roche-Tolomelli]

* Set a marker when user is done:
With this, we know how long the last screen took for him or if she/he delayed
the whole install process.
* Convert telemetry string(bool) data to simply bool
* Fix pep8 issue in tests

[Jean-Baptiste Lallement (jibel)]

Thanks Didier. Tested on bionic daily iso and it works as expected, no regression detected. Approved.

review: Approve

=== modified file 'autopilot/ubiquity_autopilot_tests/tests/__init__.py'
--- autopilot/ubiquity_autopilot_tests/tests/__init__.py	2018-03-22 15:11:13 +0000
+++ autopilot/ubiquity_autopilot_tests/tests/__init__.py	2018-03-26 16:53:30 +0000
@@ -239,7 +239,8 @@
 
         :param thirdParty: Boolean, if True selects install third-party
                                     software
-        :param minimal_installation: Boolean, if True selects minimal installation option
+        :param minimal_installation: Boolean, if True selects minimal
+                                       installation option
 
         :param networkConnection: Boolean if True checks the network state box
                                     is visible and objects are correct, If

=== modified file 'ubiquity/frontend/gtk_ui.py'
--- ubiquity/frontend/gtk_ui.py	2018-03-13 10:25:23 +0000
+++ ubiquity/frontend/gtk_ui.py	2018-03-26 16:53:30 +0000
@@ -874,6 +874,7 @@
         misc.drop_privileges_save()
         self.progress_mode.set_current_page(
             self.progress_pages['progress_bar'])
+        telemetry.get().add_stage('user_done')
 
         if not self.slideshow:
             self.page_mode.hide()

=== modified file 'ubiquity/frontend/kde_ui.py'
--- ubiquity/frontend/kde_ui.py	2018-03-13 10:25:23 +0000
+++ ubiquity/frontend/kde_ui.py	2018-03-26 16:53:30 +0000
@@ -607,6 +607,7 @@
         return webView
 
     def start_slideshow(self):
+        telemetry.get().add_stage('user_done')
         slideshow_dir = '/usr/share/ubiquity-slideshow'
         slideshow_locale = self.slideshow_get_available_locale(slideshow_dir,
                                                                self.locale)

=== modified file 'ubiquity/telemetry.py'
--- ubiquity/telemetry.py	2018-03-13 10:25:23 +0000
+++ ubiquity/telemetry.py	2018-03-26 16:53:30 +0000
@@ -66,6 +66,11 @@
         """Record anynomized partition method"""
         self._metrics['PartitionMethod'] = method
 
+    def _db_get_bool(self, value):
+        if value == 'true':
+            return True
+        return False
+
     @raise_privileges
     def done(self, db):
         """Close telemetry collection
@@ -74,10 +79,13 @@
         destination file"""
         self.add_stage('done')
 
-        self._metrics['DownloadUpdates'] = db.get('ubiquity/download_updates')
+        self._metrics['DownloadUpdates'] = self._db_get_bool(
+            db.get('ubiquity/download_updates'))
         self._metrics['Language'] = db.get('localechooser/languagelist')
-        self._metrics['Minimal'] = db.get('ubiquity/minimal_install')
-        self._metrics['RestrictedAddons'] = db.get('ubiquity/use_nonfree')
+        self._metrics['Minimal'] = self._db_get_bool(
+            db.get('ubiquity/minimal_install'))
+        self._metrics['RestrictedAddons'] = self._db_get_bool(
+            db.get('ubiquity/use_nonfree'))
         self._metrics['Stages'] = self._stages_hist
 
         target_dir = os.path.dirname(self._dest_path)