Code review comment for lp:~didrocks/quickly/install-in-opt

/opt/extras should be /opt/extras.ubuntu.com according to the discussion in the mailing list, I believe. But you mention that you are waiting for final, final approval.

15 if get_python_mkdebian_version() > 2.22:
16 command.append("--force-copyright")
17 + if get_python_mkdebian_version() > 2.23:
18 + command.append("--force-rules")

Should just be:

if get_python_mkdebian_version() > 2.22:
    command.append("--force-copyright")
    command.append("--force-rules")

as --force-rules was added in 2.23.

oopss, fixing

+print _("Then your application will be reviewed by the application review board.")

I didn't see anything that would notify the ARB. I assume that's a TODO item?

Right, as mentionned and pending email on the ARB about "what to do with the submitubuntu command, should we always install in /opt?"

+def update_file_content(filename, start_marker, end_marker, replacing_content):

Nice function. :) Though ideally, it would use set_file_contents() from quicklyutils.py (after moving it to templatetools).

Not really the same the same, set_files_contents exchanges some values, here this one is to add/remove content between tags. the licence command should use it.