Code review comment for lp:~didrocks/quickly/install-in-opt
Revision history for this message
| Michael Terry (mterry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
+# Copyright 2009 Didier Roche
Should that be 2010 Canonical?
17 + command = ['python-mkdebian', '--force-control', '--force-rules']
You probably want to version-guard --force-rules like we did for --force-copyright.
Could we call it 'submit' rather than 'submitubuntu'?
Could we not reduce the duplicated logic between 'submitubuntu' and 'release' more?
Is there a reason we don't just default installopt to True? Seems bad for developers to be testing one thing and submitting a different one. Especially since any hard-coded paths they used will want to be different.