Merge lp:~didrocks/location-service/build-with-system-gmock into lp:location-service/trunk

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 17
Merged at revision: 20
Proposed branch: lp:~didrocks/location-service/build-with-system-gmock
Merge into: lp:location-service/trunk
Diff against target: 40 lines (+12/-3)
2 files modified
debian/control (+1/-1)
tests/CMakeLists.txt (+11/-2)
To merge this branch: bzr merge lp:~didrocks/location-service/build-with-system-gmock
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Thomas Voß (community) Approve
Review via email: mp+173407@code.launchpad.net

Commit message

Adapt to new gmock snapshot (which doesn't ship anymore shared lib)

Description of the change

Adapt to new gmock snapshot (which doesn't ship anymore shared lib)

/!\ need the new gmock snapshot in distro first (right now in ppa:didrocks/ppa)

To post a comment you must log in.
Revision history for this message
Thomas Voß (thomas-voss) wrote :

LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

approving globally now that new gmock is available

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-07-04 11:01:19 +0000
+++ debian/control 2013-07-08 06:41:23 +0000
@@ -9,7 +9,7 @@
9 debhelper (>= 9),9 debhelper (>= 9),
10 doxygen,10 doxygen,
11 geoclue-ubuntu-geoip,11 geoclue-ubuntu-geoip,
12 google-mock,12 google-mock (>= 1.6.0+svn437),
13 lcov,13 lcov,
14 libboost-program-options-dev,14 libboost-program-options-dev,
15 libboost-system-dev,15 libboost-system-dev,
1616
=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt 2013-06-10 11:10:00 +0000
+++ tests/CMakeLists.txt 2013-07-08 06:41:23 +0000
@@ -1,5 +1,3 @@
1add_subdirectory(/usr/src/gtest gtest)
2
3find_package(Threads)1find_package(Threads)
42
5option(3option(
@@ -13,6 +11,17 @@
13 message(STATUS "Executing test suite under dbus-test-runner")11 message(STATUS "Executing test suite under dbus-test-runner")
14endif (LOCATION_SERVICE_ENABLE_DBUS_TEST_RUNNER)12endif (LOCATION_SERVICE_ENABLE_DBUS_TEST_RUNNER)
1513
14# Build with system gmock and embedded gtest
15set (GMOCK_INCLUDE_DIR "/usr/include/gmock/include" CACHE PATH "gmock source include directory")
16set (GMOCK_SOURCE_DIR "/usr/src/gmock" CACHE PATH "gmock source directory")
17set (GTEST_INCLUDE_DIR "${GMOCK_SOURCE_DIR}/gtest/include" CACHE PATH "gtest source include directory")
18
19add_subdirectory(${GMOCK_SOURCE_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock")
20include_directories (
21 ${GMOCK_INCLUDE_DIR}
22 ${GTEST_INCLUDE_DIR}
23)
24
16add_executable(25add_executable(
17 acceptance_tests26 acceptance_tests
18 acceptance_tests.cpp27 acceptance_tests.cpp

Subscribers

People subscribed via source and target branches