dee

Merge lp:~didrocks/dee/add_python_3 into lp:dee

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 383
Merged at revision: 381
Proposed branch: lp:~didrocks/dee/add_python_3
Merge into: lp:dee
Prerequisite: lp:~mterry/dee/modern-build
Diff against target: 43 lines (+9/-2)
2 files modified
debian/changelog (+5/-0)
debian/rules (+4/-2)
To merge this branch: bzr merge lp:~didrocks/dee/add_python_3
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Terry Approve
Review via email: mp+133491@code.launchpad.net

This proposal supersedes a proposal from 2012-11-08.

Commit message

ensure python3 files are handled by dh_python3

Description of the change

Have the python3 files really processed with dh_python3 instead of dh_python2
I tried to remove the already existing dh_python2 -pgir1.2-dee-1.0
W: dh_python2:334: Python 3.x location detected, please use dh_python3: debian/gir1.2-dee-1.0/usr/lib/python3

Unfortunately, if we try to use dh_python2 debian/gir1.2-dee-1.0/usr/lib/python2.7, the pyshared and overriden directories are not created.
(explicit in dh_python2 code if a path is provided). Also, -X ".*python3.*" doesn't work. So living with the warning for now.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote : Posted in a previous version of this proposal

Looks like you forgot to set the pre-requisite branch, so your changes appear with mine.

Revision history for this message
Michael Terry (mterry) wrote :

You should drop the empty override for dh_python2. But besides that it looks fine.

review: Needs Fixing
Revision history for this message
Michael Terry (mterry) wrote :

+1

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

Whoops, also you should add python3 to Build-Depends

Revision history for this message
Michael Terry (mterry) wrote :

Guh, nevermind, I'm an idiot. It's already there.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified.

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-08 14:47:32 +0000
+++ debian/changelog 2012-11-08 14:47:32 +0000
@@ -1,10 +1,15 @@
1dee (1.0.14-0ubuntu2) UNRELEASED; urgency=low1dee (1.0.14-0ubuntu2) UNRELEASED; urgency=low
22
3 [ Michael Terry ]
3 * debian/control:4 * debian/control:
4 - Update Vcs-Bzr5 - Update Vcs-Bzr
5 * debian/rules:6 * debian/rules:
6 - Update to dh9 and enable tests7 - Update to dh9 and enable tests
78
9 [ Didier Roche ]
10 * debian/rules:
11 - Call dh_python3 for python3 suppport
12
8 -- Michael Terry <mterry@ubuntu.com> Mon, 05 Nov 2012 15:28:38 -050013 -- Michael Terry <mterry@ubuntu.com> Mon, 05 Nov 2012 15:28:38 -0500
914
10dee (1.0.14-0ubuntu1) quantal; urgency=low15dee (1.0.14-0ubuntu1) quantal; urgency=low
1116
=== modified file 'debian/rules'
--- debian/rules 2012-11-08 14:47:32 +0000
+++ debian/rules 2012-11-08 14:47:32 +0000
@@ -5,7 +5,7 @@
5#export DH_VERBOSE=15#export DH_VERBOSE=1
66
7%:7%:
8 dh $@ --with python2,autoreconf8 dh $@ --with python2,python3,autoreconf
99
10override_dh_autoreconf:10override_dh_autoreconf:
11 NOCONFIGURE=1 dh_autoreconf ./autogen.sh11 NOCONFIGURE=1 dh_autoreconf ./autogen.sh
@@ -21,7 +21,9 @@
21 rm debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.pyc21 rm debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.pyc
22 rm debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.pyo22 rm debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.pyo
23 dh_install --fail-missing23 dh_install --fail-missing
24 dh_python2 -pgir1.2-dee-1.024
25override_dh_python3:
26 dh_python3 debian/gir1.2-dee-1.0/usr/lib/python3
2527
26override_dh_gencontrol:28override_dh_gencontrol:
27 dh_girepository29 dh_girepository

Subscribers

People subscribed via source and target branches