Code review comment for lp:~didrocks/cupstream2distro-config/move-unity-notifications

Revision history for this message
Francis Ginther (fginther) wrote :

unity-notifications is missing the "node_label" parameter that was defined in the phablet/shell.cfg ci_default section. The new block should be:

    unity-notifications:
      hooks: H10enable_coverage B10gcovr_run
      configurations:
        saucy-armhf:
          node_label: panda-pbuilder
          archive_artifacts: '**/coverage*.xml, **/output/*deb'
      archive_artifacts: '**/coverage*.xml'
      publish_coverage: '**/coverage*.xml'

Also the old job used 'phablet-land' to dput the packages into the phablet PPAs. Therefore, I would like Sergio to sign off on this change.

review: Needs Fixing

« Back to merge proposal