Code review comment for lp:~didrocks/autopilot/remove-circular-dep

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Thomi,

Well, you should know that packages are pushed by people having upload rights, knowing exactly how the package system work, earning that through years.

We are not touching or approving upstream code change without upstream ack. We would like the same for the packaging side (seeing in particular the number of missing replaces/conflicts we had to fix).

You are creating a circular dependency, as explained in the commit message. This is considered harmful as you can't bootstrap the distribution anymore. If you have to rebuild everything, how would you do it? If you have this breakdown of A being useless without B and B being useless without A, maybe your split doesn't make sense?

Telling python-autopilot is useless without autopilot-desktop or autopilot-touch doesn't qualify to add that dependency (it should even maybe be just a suggest). For instance, I can argue installing libunity-core-6.0-5 without unity is useless, should we have it depending on unity itself? I don't think so. I see the same rationale with python-autopilot

« Back to merge proposal