Merge lp:~dholbach/snapcraft/1498347 into lp:~snappy-dev/snapcraft/core

[Daniel Holbach]

stage package libgudev-1.0-0, which makes the godd snap actually work

[Sergio Schvezov (sergiusens)]

Thanks for this, but I don't understand :-)

This is strange, it would either be needed as a stage-package or as a build-package; if introducing it as a stage-package (to get a shared lib in the end) you should introduce fileset usage to not have the snap full of development headers and remove the build-package.

review: Needs Information

[Daniel Holbach (dholbach)]

Not sure I understand. AFAICS you need libgudev-1.0-dev installed as part of build-packages (for the build to pass locally) AND to bundle libudev-1.0-0 for the snap to work on a snappy system.

[lp:~dholbach/snapcraft/1498347]

193. By Daniel Holbach on 2015-09-22

merged lp:~mvo/snapcraft/1498347

[Sergio Schvezov (sergiusens)]

and here's the real real one ;-)

review: Approve

=== modified file 'examples/godd/snapcraft.yaml'
--- examples/godd/snapcraft.yaml	2015-09-21 05:04:31 +0000
+++ examples/godd/snapcraft.yaml	2015-09-22 13:50:22 +0000
@@ -5,12 +5,16 @@
   godd:
     exec: ./bin/godd
 summary: Simple dd like tool
-description: written in go so it is self contained and really portable, you would need to use hw-assign to access devices.
+description: Written in go with support for device auto-detection via libgudev, you would need to use hw-assign to access devices.
 icon: icon.png
 
 parts:
   godd:
     type: go-project
     source: git://github.com/mvo5/godd
-build-packages: 
-    - libgudev-1.0-dev
+    stage-packages: [libgudev-1.0-dev]
+    snap:
+     - usr/lib/x86_64-linux-gnu/libgudev-1.0.so*
+     - usr/lib/x86_64-linux-gnu/libobject-2.0.so*
+     - usr/lib/x86_64-linux-gnu/libglib-2.0.so*
+     - bin/godd*
\ No newline at end of file