Merge lp:~dholbach/help-app/break-out-po4a-operations into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Proposed by
Daniel Holbach
Status: | Merged |
---|---|
Approved by: | David Planella |
Approved revision: | 74 |
Merged at revision: | 52 |
Proposed branch: | lp:~dholbach/help-app/break-out-po4a-operations |
Merge into: | lp:~ubuntu-touch-coreapps-drivers/help-app/trunk |
Diff against target: |
152 lines (+66/-42) 1 file modified
edit-here/translations.py (+66/-42) |
To merge this branch: | bzr merge lp:~dholbach/help-app/break-out-po4a-operations |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Needs Information | ||
Review via email:
|
Commit message
Move all functionality related to po4a into its own class. This will avoid further duplication of the code and make the code in general easier to read.
To post a comment you must log in.
Looks good to me and it works. Happy to approve, but just so I make sure I understand - could you explain the rationale for the change?