Merge lp:~dholbach/help-app/1430735-pt3 into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by Daniel Holbach
Status: Merged
Merged at revision: 100
Proposed branch: lp:~dholbach/help-app/1430735-pt3
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Prerequisite: lp:~dholbach/help-app/1430735-2
Diff against target: 52 lines (+15/-12)
2 files modified
edit-here/tests/test_translations.py (+6/-4)
edit-here/translations.py (+9/-8)
To merge this branch: bzr merge lp:~dholbach/help-app/1430735-pt3
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+253167@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'edit-here/tests/test_translations.py'
--- edit-here/tests/test_translations.py 2015-03-06 15:47:49 +0000
+++ edit-here/tests/test_translations.py 2015-03-17 09:25:46 +0000
@@ -24,7 +24,9 @@
24 for entry in pofile.find_in_msgid('{filename}'):24 for entry in pofile.find_in_msgid('{filename}'):
25 (link_msgid, link_msgstr) = \25 (link_msgid, link_msgstr) = \
26 pofile.find_link_in_markdown_message(entry)26 pofile.find_link_in_markdown_message(entry)
27 self.assertNotIn(link_msgid, link_msgstr)27 if [doc for doc in self.translations.documents.docs
28 self.assertEqual(1, len(link_msgstr))28 if doc.endswith(link_msgid)]:
29 self.assertIn(po.langs[po_fn]['gettext_code'],29 self.assertNotIn(link_msgid, link_msgstr)
30 link_msgstr[0])30 self.assertEqual(1, len(link_msgstr))
31 self.assertIn(po.langs[po_fn]['gettext_code'],
32 link_msgstr[0])
3133
=== modified file 'edit-here/translations.py'
--- edit-here/translations.py 2015-03-17 09:25:46 +0000
+++ edit-here/translations.py 2015-03-17 09:25:46 +0000
@@ -212,7 +212,7 @@
212 return True212 return True
213213
214 def find_link_in_markdown_message(self, entry):214 def find_link_in_markdown_message(self, entry):
215 link_regex = r'\[.+?\]\(\{filename\}(.+?)\)'215 link_regex = r'\[.+?\]\(\{filename\}(.+?)\).*?'
216 link_msgid = re.findall(link_regex, entry.msgid)[0]216 link_msgid = re.findall(link_regex, entry.msgid)[0]
217 link_msgstr = list(re.findall(link_regex, entry.msgstr))217 link_msgstr = list(re.findall(link_regex, entry.msgstr))
218 return (link_msgid, link_msgstr)218 return (link_msgid, link_msgstr)
@@ -221,13 +221,14 @@
221 for entry in self.find_in_msgid('{filename}'):221 for entry in self.find_in_msgid('{filename}'):
222 (link_msgid, link_msgstr) = \222 (link_msgid, link_msgstr) = \
223 self.find_link_in_markdown_message(entry)223 self.find_link_in_markdown_message(entry)
224 translated_doc_fn = os.path.basename(224 if [doc for doc in documents.docs if doc.endswith(link_msgid)]:
225 documents.translated_doc_fn(link_msgid, bcp47))225 translated_doc_fn = os.path.basename(
226 if not link_msgstr:226 documents.translated_doc_fn(link_msgid, bcp47))
227 entry.msgstr = entry.msgid227 if not link_msgstr:
228 link_msgstr = [link_msgid]228 entry.msgstr = entry.msgid
229 entry.msgstr = entry.msgstr.replace(link_msgstr[0],229 link_msgstr = [link_msgid]
230 translated_doc_fn)230 entry.msgstr = entry.msgstr.replace(link_msgstr[0],
231 translated_doc_fn)
231 self.save()232 self.save()
232233
233 def find_translated_title_line(self, original_title):234 def find_translated_title_line(self, original_title):

Subscribers

People subscribed via source and target branches